Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default path for MRIUploadIncomingPath #1627

Merged
merged 3 commits into from
Mar 29, 2016
Merged

Default path for MRIUploadIncomingPath #1627

merged 3 commits into from
Mar 29, 2016

Conversation

MounaSafiHarab
Copy link
Contributor

Set default to /data/incoming (like what we have in the installation scripts) to prevent imaging_uploader from uploading to /tmp/

@MounaSafiHarab MounaSafiHarab added Release: Add to release notes PR whose changes should be highlighted in the release notes Language: SQL PR or issue that update SQL code labels Mar 17, 2016
@MounaSafiHarab MounaSafiHarab added this to the 16.0 milestone Mar 17, 2016
@codecov-io
Copy link

Current coverage is 14.65%

Merging #1627 into 16.04-dev will decrease coverage by -0.02% as of 7259416

@@            16.04-dev   #1627   diff @@
=========================================
  Files             112     112       
  Stmts           18836   18840     +4
  Branches            0       0       
  Methods          1046    1046       
=========================================
- Hit              2764    2761     -3
  Partial             0       0       
- Missed          16072   16079     +7

Review entire Coverage Diff as of 7259416

Powered by Codecov. Updated on successful CI builds.

@gluneau gluneau self-assigned this Mar 18, 2016
driusan
driusan reviewed Mar 18, 2016
View reviewed changes
SQL/2016-03-10-DefaultMRIUploadPath.sql
@@ -0,0 +1 @@
UPDATE Config AS c, ConfigSettings AS cs SET c.value="/data/incoming/" WHERE c.ConfigID=cs.ID AND cs.Name="MRIUploadIncomingPath";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should include add a where clause to only update if it's set to the default, and not overwrite existing variables. (Patch only)

@xlecours
Copy link
Contributor

Should the existing projects apply this patch?

@driusan
Copy link
Collaborator

driusan commented Mar 22, 2016

I don't think it matters.. if they've customized it, the WHERE clause will make it a no-op.

@samirdas samirdas merged commit d897d09 into aces:16.04-dev Mar 29, 2016
@christinerogers christinerogers added the Release: Breaking changes PR that contains changes that might impact the code or accepted practices of active projects label Jun 15, 2016
@christinerogers
Copy link
Contributor

@MounaSafiHarab tagged for existing projects. adding to notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gluneau gluneau

Labels
Language: SQL PR or issue that update SQL code Release: Add to release notes PR whose changes should be highlighted in the release notes Release: Breaking changes PR that contains changes that might impact the code or accepted practices of active projects
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
7 participants
@MounaSafiHarab @codecov-io @xlecours @driusan @christinerogers @samirdas @gluneau